Fix: set imagePullPolicy Always on dev container sidecar#368
Merged
Conversation
Dev container images commonly use mutable tags like :main or :latest. Without imagePullPolicy: Always, Kubernetes uses IfNotPresent for non-:latest tags, causing stale cached images to be used even after the upstream image is rebuilt. This caused the rootless dev container fix to not take effect on OpenShift because the node had the old root-requiring image cached. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dev container images use mutable tags like
:main. WithoutimagePullPolicy: Always, Kubernetes defaults toIfNotPresentfor non-:latesttags, causing stale cached images on nodes. This caused the rootless dev container fix (pulp/pulp-service#1075) to not take effect on OpenShift — the node had the old root-requiring image cached and kept using it.Fix
One line: add
ImagePullPolicy: corev1.PullAlwaysto the dev container spec inkubernetes.go.Test plan
go test ./internal/runtime/passes (existing k8s tests verify container spec)