Make gapstone go-get-able without pre-installing Capstone.#22
Open
BenLubar wants to merge 3 commits intobnagy:masterfrom
Open
Make gapstone go-get-able without pre-installing Capstone.#22BenLubar wants to merge 3 commits intobnagy:masterfrom
BenLubar wants to merge 3 commits intobnagy:masterfrom
Conversation
Owner
|
Hi! Thanks for the code. If you can fix the CI errors then I'm OK to merge this. Looks like it's just breaking on old go? |
Contributor
|
@bnagy Looking at the build errors I see this
It seems like maybe Travis CI just had some connectivity issues. Would you be able to retry the build and see if it builds and tests cleanly? I think this PR is a nice improvement and would be in favor of merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes tests failing on Windows due to line endings in .SPEC files.
Tested on Windows 10 (mingw-gcc 5.3, Go 1.11beta2) and Ubuntu 18.04 (gcc 7.3, Go 1.10.3).