Skip to content

Module name special character handling fix #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathan-ahn merged 2 commits into from
Jun 12, 2026
Merged

Module name special character handling fix #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0abd763
Fixing special character handling
nathan-ahn Jun 12, 2026
2850ff3
v0.9.1
nathan-ahn Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-app-clip",
"version": "0.9.0",
"version": "0.9.1",
"description": "Config plugin to add an App Clip to a React Native iOS app",
"main": "build/index.js",
"types": "build/index.d.ts",
Expand Down
4 changes: 3 additions & 1 deletion plugin/src/withPlist.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const withPlist: ConfigPlugin<{
},
NSAllowsLocalNetworking: config.developmentClient,
},
CFBundleName: "$(PRODUCT_NAME)",
CFBundleName: "$(PRODUCT_MODULE_NAME)",
CFBundleDisplayName: "$(PRODUCT_NAME)",
CFBundleIdentifier: "$(PRODUCT_BUNDLE_IDENTIFIER)",
CFBundleVersion: "$(CURRENT_PROJECT_VERSION)",
Expand All @@ -73,6 +73,8 @@ export const withPlist: ConfigPlugin<{
}
}

infoPlist.CFBundleName = "$(PRODUCT_MODULE_NAME)";

fs.mkdirSync(path.dirname(filePath), {
recursive: true,
});
Expand Down
Loading