fix(commands): reconcile targets when enabling downshift - #25
Merged
Conversation
Capture the complete active model target, make managed target switches idempotent, and establish the configured premium or economy policy before reporting a session as enabled. Keep failed reconciliation paused without a contradictory success message, while preserving handoff ordering and session-level enable overrides. Extend the lifecycle adapter tests for updated targets, current-model capture, idempotence, failures, and internal event suppression, and document the new /downshift on behavior.
Activate the configured economy target directly when enabling above the threshold without a handoff, instead of allowing maybeDownshift to return early from a retained economy position. Cover the full lifecycle from an automatic economy transition through session disablement, configuration change, and re-enablement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/downshift onto the latest premium/economy policy before reporting successBehavior
premiumSource: "current"captures both the active model and active thinking level at enable time/downshift oncontinues to override a globally disabled configurationTests
npm run checkgit diff --check