New features and a couple of bugfixes#17
Open
josedpedroso wants to merge 14 commits into
Open
Conversation
josedpedroso
commented
Jan 19, 2023
josedpedroso
commented
Contributor
- I never got to make an actual css skin for Bragi MPD. Instead I decided to make a bunch of settings to customize its colors in a simple way, with hue, saturation, and other css filters.
- Setting mediaMetadata allows track info to be displayed by, eg, bluetooth players.
More sanitization of config parameter. Fixed page title when idle. Volume icons now show mute status using mute css class. mute css class applies a red circle border to the icons.
…converted to arraybuffer by mpd.js before being sent. Recent versions of websockify don't have the --auto-pong option; removed it from start_bragi.
Pausing stream from a notification now pauses MPD too. Doesn't work 100% in firefox mobile because the event is deferred until the tab is in foreground. Color settings restored later during init to avoid accessing local storage too soon. Encoder for data to be sent over websocket now explicitly uses utf-8, as rschroll suggested.
This is for Firefox mobile, which doesn't send the MediaMetadata info to bluetooth receivers, only the page title.
Set audio element title, which may be used by some browsers and OSes for media notifications. Set empty mediaMetadata when not streaming audio. Workaround for Firefox not updating media notification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.