test: add docSupport test and add docSupport version check#223
Merged
Conversation
Contributor
|
I think the issue is GitHub action's 6hrs running limit. There's too many checks being executed in a single action. Dividing checks to several nix builds may help |
Owner
Author
I saw one of the earlier runs off the other pr saying "pushing is disabled" in the post run of cachix. But I see all recent runs so not execute the post run anymore regardless due to the 6h limit. I could've sworn this used to work. I can manually build Linux locally, but cannot do this for macOS. I'll probably need to parallelize the build some more. |
There is a do-install-doc issue related to ruby version < 3.4. This commit checks doc support for ruby version >= 3.4 and add guard perventing docSupport be used in parallel build with early versions. See: ruby/rubygems#7580
rdoc tries to create XDG_DATA_DIR (defaulting to $HOME/.local/share) during the build, but $HOME is read-only in the Nix sandbox. This adds a writable $HOME during the preConfigure phase, and applies the same fix to the docSupport tests in flake.nix. See: #221 Co-Authored-By: Sander <hey@sandydoo.me>
bobvanderlinden
force-pushed
the
docSupportChecks
branch
from
17a2474 to
7a8f657
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicate of #212 but updated to use parallel CI from #225, so that builds won't timeout on GHA.
Closes #212
Closes #221