Remove old PHPStan configuration, resolve latest errors#3657
Merged
bobvandevijver merged 1 commit into6.0from Dec 18, 2025
Merged
Remove old PHPStan configuration, resolve latest errors#3657bobvandevijver merged 1 commit into6.0from
bobvandevijver merged 1 commit into6.0from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes outdated PHPStan configuration and resolves static analysis errors. The changes streamline the PHPStan setup by removing obsolete ignore rules and directory scans, while fixing the underlying issues that were being suppressed.
- Removed PHPStan configuration workarounds that are no longer needed
- Fixed error handling in ContentFixtures to properly catch exceptions instead of using an empty finally block
- Added explicit type hint for upload result to resolve PHPStan type inference issue
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/DataFixtures/ContentFixtures.php | Replaced empty finally block with proper exception handling using catch block |
| src/Controller/Backend/Async/UploadController.php | Added type hint annotation and import for File class to resolve PHPStan type issues |
| phpstan.dist.neon | Removed obsolete configuration including scanDirectories, ignoreErrors, and commented-out services |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bobvandevijver
force-pushed
the
remove-old-phpstan-config
branch
from
af46a67 to
08d2cbe
Compare
bobvandevijver
force-pushed
the
remove-old-phpstan-config
branch
from
08d2cbe to
bcb4001
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.