Fix possible path traversal through thumbnail endpoint#3661
Merged
bobvandevijver merged 2 commits into5.2from Dec 30, 2025
Merged
Fix possible path traversal through thumbnail endpoint#3661bobvandevijver merged 2 commits into5.2from
bobvandevijver merged 2 commits into5.2from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a security vulnerability by preventing path traversal attacks through the thumbnail endpoint. The fix ensures that file paths are properly validated and canonicalized before processing image requests.
Key Changes:
- Added path canonicalization to validate and sanitize file paths before use
- Implemented proper exception handling for invalid paths and missing files
- Added safety checks to return error images when path validation or file operations fail
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bobvandevijver
force-pushed
the
fix-path-traversal-5.2
branch
from
cab5876 to
b41eeb2
Compare
tobias-93
approved these changes
Dec 30, 2025
bobvandevijver
force-pushed
the
fix-path-traversal-5.2
branch
2 times, most recently
from
27cef1c to
5f43358
Compare
bobvandevijver
force-pushed
the
fix-path-traversal-5.2
branch
from
5f43358 to
124d10d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.