Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Bolt Redactor extension to be compatible with Bolt 6, modernizing the codebase to use PHP 8.2+ features and updating dependencies.
- Modernized PHP code using constructor property promotion, readonly properties, and PHP 8+ syntax
- Updated Symfony dependencies (Security component namespace, attribute-based routing and security)
- Added static analysis tools (PHPStan, Rector, ECS) with configuration files
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updated PHP requirement to 8.2+, Bolt Core to 6.0, and added development tools |
| src/TwigExtension.php | Modernized constructor with property promotion and replaced container dependency with direct parameters |
| src/RedactorInjectorWidget.php | Updated to use Request::METHOD_GET constant |
| src/RedactorConfig.php | Applied constructor property promotion, added type hints, and improved null safety |
| src/Extension.php | Added type annotations for container parameters |
| src/Entity/RedactorField.php | Converted from annotation to attribute syntax and added return type |
| src/Controller/Upload.php | Modernized with attributes, property promotion, and updated method signatures |
| src/Controller/Images.php | Applied similar modernization patterns and added PHPDoc type hints |
| config/services.yaml | Updated Doctrine mapping type from annotation to attribute |
| rector.php | Added Rector configuration for code modernization |
| phpstan.dist.neon | Added PHPStan configuration for static analysis |
| ecs.php | Added new ECS configuration replacing old YAML config |
| easy-coding-standard.yml | Removed old YAML configuration file |
| .github/workflows/code_analysis.yaml | Added CI workflow for code quality checks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bobvandevijver
force-pushed
the
dev-6.x
branch
3 times, most recently
from
357eed4 to
86cf480
Compare
tobias-93
requested changes
Nov 13, 2025
bobvandevijver
force-pushed
the
dev-6.x
branch
from
be0009f to
914e6db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.