Restoring helpful code documentation and context#856
Open
AndreAugustoDev wants to merge 2 commits intobongodevs:mainfrom
Open
Restoring helpful code documentation and context#856AndreAugustoDev wants to merge 2 commits intobongodevs:mainfrom
AndreAugustoDev wants to merge 2 commits intobongodevs:mainfrom
Conversation
Restores technical documentation, JSDocs, and core logic comments previously removed in 3834fcd. This ensures code maintainability while preserving the updated branding and dependency versions.
TypeScript 5.9 now includes `Intl.DurationFormat` type declarations natively
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lavamusic Pull Request
Description
This PR restores essential JSDoc blocks, technical context, and utility functions that were removed in commit 3834fcd.
In my opinion, while the previous cleanup aimed to reduce noise, it removed documentation that is vital for the project's long-term maintainability.
This restoration should be analyzed with care to ensure we have the right balance of code clarity.
Type of Change
Changes Made
Lavamusicclass to explain "why" certain logic exists.getCountryCodefunction insrc/utils/CountryEmojiFlag.ts, which is necessary for the locale system.Move,Lyrics, andDeployto assist with future refactors and debugging.Checklist
pnpm formatThank you for contributing to Lavamusic!