tmt: Temporarily disable unified storage test#2014
Conversation
|
I'm very unsure if adding |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request temporarily disables the unified storage test to unblock other work, which is a reasonable approach. I've added one suggestion to include a FIXME comment. This will serve as a reminder to re-enable the test once the underlying issue is resolved, improving maintainability.
| # tmt: | ||
| # summary: Onboard to unified storage, build derived image, and switch to it | ||
| # duration: 30m | ||
| # enabled: false |
There was a problem hiding this comment.
To ensure this temporarily disabled test is not forgotten, it would be good practice to add a FIXME or TODO comment explaining why it's disabled and what is needed for it to be re-enabled. This helps with future maintenance.
# enabled: false # FIXME: Re-enable once SELinux issue is resolved (see https://github.com/bootc-dev/bootc/pull/1986)
There's something weird going on with selinux labeling, see discussion at: bootc-dev#1986 Disable the test for now while we troubleshoot, because it's blocking other stuff that needs to merge. Signed-off-by: John Eckersberg <jeckersb@redhat.com>
jeckersb
force-pushed
the
disable-unified-tests
branch
from
ea6338d to
6e3c6db
Compare
Yeah didn't work, new version just early-returns from main in the test instead of disabling the test. |
2 participants
There's something weird going on with selinux labeling, see discussion
at:
#1986
Disable the test for now while we troubleshoot, because it's blocking
other stuff that needs to merge.
Signed-off-by: John Eckersberg jeckersb@redhat.com