A better way to show Borg's errors#2221
A better way to show Borg's errors#2221ahmedhosssam wants to merge 7 commits intoborgbase:masterfrom
Conversation
|
Please review @VandalByte and let me know if this is suitable to be added. IIRC we already have an error dialog for the whole app in the code. This could reuse it, but just for Borg errors. Thanks! |
|
I tested the changes by introducing errors, and everything works as expected for various borg commands. One issue I encountered is with I think the error already existed, but it didn’t affect the tests. Now that the new error dialog surfaces it in a separate window, it's causing the tests to hang. |
|
I have added the fixes with the commit: c8ee821 on the branch master...VandalByte:vorta:fix-better-borg-error The commit also includes some minor bug fixes for the previously merged Change Passphrase feature. |
|
This also fixes my recent peeve with Vorta log display. |
Description
Fixes #1940
I think it would be better to show Borg's error messages inside Vorta's exception dialog instead of relying on the tiny progress event box.
Now most of Borgs' commands would have a "started" and "finished" messages appears in the progress event box, and the errors would appear in the exception dialog.
I also added
finished_eventfunction tomountandumuont, I'm not sure but I think it should have error handling also, just as the rest of the commands.Now the command that doesn't have that change are
info_archive,info_repo,init,version, andrename.Related Issue
#1940
How Has This Been Tested?
I tested it by changing Borg's commands from the source code to force them to fail and return non-zero code, and the result for all the commands is just like the screen record.
Screen Record:
2025-03-20.03-14-30.mp4
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.