Add missing timeout configurations to CI workflows#2397
Open
mr-raj12 wants to merge 1 commit intoborgbase:masterfrom
Open
Add missing timeout configurations to CI workflows#2397mr-raj12 wants to merge 1 commit intoborgbase:masterfrom
mr-raj12 wants to merge 1 commit intoborgbase:masterfrom
Conversation
Fixes borgbase#2396 - Add 15-minute timeout to lint job - Add 5-minute timeout to prepare-matrix job - Add 60-minute timeout to tmate debug steps Without proper timeouts, jobs default to 360 minutes and can waste CI runner resources if they hang. These timeouts prevent indefinite hangs while providing sufficient buffer for legitimate slow runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds timeout configurations to CI workflow jobs that were missing them, preventing potential indefinite hangs and wasted runner resources.
Changes:
timeout-minutes: 15tolintjob (test.yml:21)timeout-minutes: 5toprepare-matrixjob (test.yml:36)timeout-minutes: 60to bothtmatedebug steps (test.yml:85, 133)Related Issue
Fixes #2396
Motivation and Context
Without proper timeout configurations, GitHub Actions jobs default to 360 minutes (6 hours). If a job hangs due to network issues, stuck processes, or forgotten debug sessions, it wastes CI runner resources and delays feedback to contributors.
While PR #2353 addressed test-level hangs through comprehensive mocking, this PR adds workflow-level timeout protections as a defense-in-depth measure.
The chosen timeout values provide generous buffers for legitimate slow runs while preventing excessive resource consumption:
How Has This Been Tested?
yaml.safe_load()gh workflow view.github/workflows/test.ymlThe timeouts themselves will be validated when CI runs on this PR.
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.