-
-
Notifications
You must be signed in to change notification settings - Fork 8
Permanently skip mas account check
#51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permanently skip mas account check
#51
Conversation
Given borksh#42 's root cause issue shows no sign of being addressed, just don't run `mas account` anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 1 Warning | |
|---|---|
| Are you sure we don't need to add/update tests? |
Generated by 🚫 Danger
Generated by 🚫 Danger |
|
Looking into the failed Checks... Yeah, that makes sense. I'll have to remove that test too. |
Given we're no longer checking if the user has logged in, then the first of these removed tests will always fail. The second two are redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ✅ Nice work. | |
|---|---|
| ✅ |
Generated by 🚫 Danger
|
Well... now this is a weird one, that wasn't broken before... That one didn't fail on the previous run, on a similar macOS version fails on my machine also, and in the same way |
… past 11 months Previously, fails on macOS: ``` not ok 173 file install: if compiled, uses stored variable # (in test file test/type-file.bats, line 150) # `borkfiles__cGF0aC9mcm9tL3NvdXJjZQo="$(base64 Readme.md)"' failed with status 64 # base64: invalid argument Readme.md # Usage: base64 [-Ddh] [-b num] [-i in_file] [-o out_file] # -b, --break break encoded string into num character lines # -Dd, --decode decodes input # -h, --help display this message # -i, --input input file (default: "-" for stdin) # -o, --output output file (default: "-" for stdout) ``` (although, why it worked fine 11 months ago, i have no idea) New syntax for the base64 part of the test should work the same on both Darwin and Linux
|
ah, it's one of those tests. one of those "how did this ever work?!" kind of tests. Because indeed, Whereas the linux version... https://linux.die.net/man/1/base64 just takes the filename. (the answer to how it ever worked is probably that the GitHub Runner now runs a newer macOS version than it did 11 months ago, and previously it somehow had linux-flavor base64) Thankfully, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ✅ Jolly good show. | |
|---|---|
| ✅ |
Generated by 🚫 Danger
|
@skylarmacdonald : Ready for review :) |
|
LGTM! Thanks for taking this on. |
Given #42 's root cause issue shows no sign of being addressed, just don't run
mas accountanymoreThen I'm implementing #49 (comment)