fix: tweak - #25
Merged
Merged
Conversation
Adds a config.source switch ("gcs" or "git") so bucketup can serve content
cloned from a git repo over SSH, in addition to the existing GCS bucket
support. Private repos authenticate via a read-only deploy key mounted from
an existing Kubernetes secret. This is a breaking change to values.yaml:
bucketName moves to config.gcs.bucketName.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
common-0.8.0's common.pod.template.tpl renders the pod "volumes:" key at the wrong indentation, nesting it under spec.template instead of spec.template.spec, which the API server rejects as an unknown field. Verified against a real kind cluster with the git deploy-key secret set; the Deployment was rejected before this fix. Inject the deploy-key volume via the bucketup.deployment override merge instead of .Values.web.volumes so the buggy code path is never triggered. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.