Handle column type methods using __call magic method#50
Open
khalilst wants to merge 2 commits intobosnadev:masterfrom
Open
Handle column type methods using __call magic method#50khalilst wants to merge 2 commits intobosnadev:masterfrom
khalilst wants to merge 2 commits intobosnadev:masterfrom
Conversation
khalilst
force-pushed
the
type-methods-by-magic-method-call
branch
from
f790287 to
0fb141f
Compare
khalilst
force-pushed
the
type-methods-by-magic-method-call
branch
from
0fb141f to
a157287
Compare
rogervila
reviewed
Nov 28, 2022
| return "character({$column->length})"; | ||
| } | ||
| if(substr($method, 0, 4) === 'type') { | ||
| $type = substr($method, 4, strlen($method) - 4); |
There was a problem hiding this comment.
@khalilst it should also use strtolower to ensure types work no matter how many capital letters are used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes MOST of the column type methods and handle them using
__callmethod.It will support the probably missing types.
And it reduced files size from 8360 to 4415 (
46%lower) and line count from 348 to 175 (49%lower).