feat(conformance): flip security.no-critical-vulns to met (vendored vuln-gate)#103
Merged
Conversation
…d vuln-gate
Vendors the upstream gates/vuln-gate.mjs (from the re-vendored conformance-kit
e8838ed), wires it as a fail-closed step in the brand-checks conformance job
(VULN_OMIT_DEV=false → all deps), and declares evidence.vulns
{ knownCriticalOrHighVulns: 0 }. The gate re-runs `npm audit` and fails closed on
any critical/high, so the committed 0 cannot drift — same discipline as axe.
Scanned: 0 critical / 0 high. Replaces the hand-rolled scripts/check-vulns.mjs
(closed PR #99). Lock regenerated (46 files @ e8838ed).
Closes prx-2efn.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flips
security.no-critical-vulnsto met honestly, using the upstream gate now available via the re-vendor (#102) — superseding the hand-rolledscripts/check-vulns.mjs(closed PR #99).gates/vuln-gate.mjsfrom conformance-kit e8838ed (lock regenerated → 46 files @ e8838ed).conformancejob (VULN_OMIT_DEV=false→ all deps), so it re-runsnpm auditand fails CI on any critical/high — the committed0can't drift (same discipline as axe).evidence.vulns { knownCriticalOrHighVulns: 0 }(+_gatesdoc).Verified locally (nix devshell)
nix build .#site✓Closes prx-2efn. Draft until CI is green.
🤖 Generated with Claude Code