fix(navbar): wire MobileNavMenu onClose

[ryzen-xp]

• Close Wire or remove the unused onClose prop on MobileNavMenu instead of suppressing the lint rule #296

Summary

Wire up the existing onClose prop on MobileNavMenu by adding a close button inside the mobile menu, and remove the inline eslint suppression. This keeps the component contract explicit and gives users a direct way to dismiss the menu.

Changes

• Added a close button inside MobileNavMenu that calls onClose()
• Removed the @typescript-eslint/no-unused-vars disable from components/ui/resizable-navbar.tsx
• Removed an unrelated unused @jest/globals import in components/reputation/__tests__/my-claims.test.ts so TypeScript can pass in this workspace

Summary by CodeRabbit

• Bug Fixes
  • Improved the mobile navigation menu by adding a dedicated “close” button for quicker dismissal.
• Tests
  • Reformatted and aligned existing automated tests for claim status normalization and grouping, keeping all test expectations and inputs the same.
• Chores
  • Updated navigation component formatting and removed an unused-variable suppression without changing navigation behavior.

[vercel]

@ryzen-xp is attempting to deploy a commit to the Threadflow Team on Vercel.

A member of the Team first needs to authorize it.

[drips-wave]

@ryzen-xp Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 58897cb0-10da-4912-9d4e-2b7e72516665

📥 Commits

Reviewing files that changed from the base of the PR and between 6c0fad3 and b68f941.

📒 Files selected for processing (2)

• components/reputation/__tests__/my-claims.test.ts
• components/ui/resizable-navbar.tsx

✅ Files skipped from review due to trivial changes (1)

• components/reputation/tests/my-claims.test.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• components/ui/resizable-navbar.tsx

---

📝 Walkthrough

Walkthrough

The PR adds a close button to the mobile navbar menu, removes an unused ESLint suppression, and keeps nearby prop/type formatting changes. It also reformats the my-claims Jest test without changing its assertions.

Changes

Navbar close control

Layer / File(s)	Summary
Mobile close button and prop wiring components/ui/resizable-navbar.tsx	Navbar keeps the same visible prop passing shape, MobileNavMenu removes the unused-variable suppression and renders a close button that calls onClose, and the open-menu content keeps the same children rendering.
NavbarButton prop union formatting components/ui/resizable-navbar.tsx	NavbarButton reformats the polymorphic Tag prop union between anchor and button variants without changing the accepted props or runtime behavior.

My-claims test cleanup

Layer / File(s)	Summary
Test formatting update components/reputation/__tests__/my-claims.test.ts	my-claims.test.ts updates line wrapping and indentation for the existing test cases while keeping the same normalizeStatus and getClaimsBySection assertions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• boundlessfi/bounties#76: Both PRs change components/ui/resizable-navbar.tsx around MobileNavMenu and its onClose contract.

Poem

A bunny tapped the navbar’s door,
and clicked a little X once more.
Jest kept its claims in tidy rows,
while status hops where logic flows.
Soft thump—small changes, neat and bright 🐰

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: wiring MobileNavMenu onClose.
Linked Issues check	✅ Passed	The PR uses onClose via a close button and removes the eslint disable, satisfying the linked issue.
Out of Scope Changes check	✅ Passed	No obvious unrelated functional changes were introduced; the test-file import cleanup and formatting support the same build goal.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Benjtalkshow]

Thanks, CI is green and the eslint disable is properly removed. One visual
bug: ml-auto on a flex-column child does nothing (it only pushes right in
flex-row), so the close button will render at the left edge instead of the
top-right — please change ml-auto to self-end, or wrap the button in
<div className="flex w-full justify-end">. Also please limit the
reformatting in Navbar, NavbarButton, and my-claims.test.ts to lines you're
actually changing (the @jest/globals import removal is fine, the rest is
Prettier-on-save churn that inflates the diff). Finally, attach a
screenshot of the open mobile menu showing the close button position so I
can verify the fix visually before merging.

[ryzen-xp]

working on !!!

[ryzen-xp]

working on !!!

[ryzen-xp]

[Benjtalkshow]

LGTM!