Skip to content

Minor fixes#80

Closed
totork wants to merge 6 commits into
boutproject:mainfrom
totork:master-fix-progress-bar
Closed

Minor fixes#80
totork wants to merge 6 commits into
boutproject:mainfrom
totork:master-fix-progress-bar

Conversation

@totork

@totork totork commented Jun 16, 2026

Copy link
Copy Markdown
Contributor
  1. The change regarding psi in GEQDSK is needed to create TCV X-21 grids. Otherwise I do get an error because of different dimensions
  2. Using Byfunc can yield negative fields and thus negative cell Areas. Magnetic flux conservation should also use the total magnetic field and not just the toroidal component I think.
  3. Run add_dagp() by default. Otherwise Hermes-3 will throw an error anyway.

@dschwoerer

Copy link
Copy Markdown
Collaborator
  1. The change regarding psi in GEQDSK is needed to create TCV X-21 grids. Otherwise I do get an error because of different dimensions

Ok, it would be nice to have a test for this.
Also remove the broken code, rather then comment it out

2. Using Byfunc can yield negative fields and thus negative cell Areas. Magnetic flux conservation should also use the total magnetic field and not just the toroidal component I think.

We disagree on this.

3. Run add_dagp() by default. Otherwise Hermes-3 will throw an error anyway.

I think this is uncontroversial and could be merged, if it would be a separate PR.

Could you force push, rather then add an extra revert commit?

@totork totork closed this Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants