Minor fixes#80
Closed
totork wants to merge 6 commits into
Closed
Conversation
totork
commented
Jun 16, 2026
Contributor
- The change regarding psi in GEQDSK is needed to create TCV X-21 grids. Otherwise I do get an error because of different dimensions
- Using Byfunc can yield negative fields and thus negative cell Areas. Magnetic flux conservation should also use the total magnetic field and not just the toroidal component I think.
- Run add_dagp() by default. Otherwise Hermes-3 will throw an error anyway.
Collaborator
Ok, it would be nice to have a test for this.
We disagree on this.
I think this is uncontroversial and could be merged, if it would be a separate PR. Could you force push, rather then add an extra revert commit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.