Skip to content

ci: Fix benchmark artifact name #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theofidry wants to merge 12 commits into
base: main
Choose a base branch
from
Open

ci: Fix benchmark artifact name #1209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
942d5e6
ci: Fix benchmark artifact name
theofidry Nov 25, 2023
fd47cb6
retry
theofidry Nov 25, 2023
aaa781f
add debug statement
theofidry Nov 25, 2023
3b22359
fix config
theofidry Nov 25, 2023
21ff5cf
upload directory
theofidry Nov 25, 2023
fe76d49
debugt
theofidry Nov 25, 2023
8c63fc6
fix directory
theofidry Nov 25, 2023
8b441b9
change path
theofidry Nov 25, 2023
f51fc50
change path
theofidry Nov 25, 2023
3206e3f
copy dist
theofidry Nov 26, 2023
8a0faaa
debug
theofidry Nov 26, 2023
55b47e5
add XML
theofidry Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/benchmark.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: '8.2'
extensions: xml
ini-values: phar.readonly=0, display_errors=On, error_reporting=-1
tools: composer
coverage: none
Expand All @@ -50,8 +51,8 @@ jobs:
- uses: actions/upload-artifact@v3
name: Upload the Benchmark results
with:
name: bench-main-result
path: dist/bench-branch-main-result.xml
name: bench-branch-main-result
path: dist/

pr-bench-test:
runs-on: ubuntu-latest
Expand All @@ -66,6 +67,7 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: '8.2'
extensions: xml
ini-values: phar.readonly=0, display_errors=On, error_reporting=-1
tools: composer
coverage: none
Expand Down Expand Up @@ -101,6 +103,7 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: '8.2'
extensions: xml
ini-values: phar.readonly=0, display_errors=On, error_reporting=-1
tools: composer
coverage: none
Expand All @@ -124,6 +127,9 @@ jobs:
with:
name: bench-branch-main-result

- name: Check history
run: vendor-bin/phpbench/vendor/bin/phpbench log

- name: Run PHPBench for PR branch
run: make phpbench_pr

Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ phpbench_pr: $(PHPBENCH_BIN) $(PHPBENCH_WITH_COMPACTORS_VENDOR_DIR) $(PHPBENCH_W

.PHONY: phpbench_main
phpbench_main: $(PHPBENCH_BIN) $(PHPBENCH_WITH_COMPACTORS_VENDOR_DIR) $(PHPBENCH_WITHOUT_COMPACTORS_VENDOR_DIR)
$(PHPBENCH) run tests/Benchmark --report=benchmark --tag=main
$(PHPBENCH) run tests/Benchmark --report=benchmark --tag=main -vvv


#---------------------------------------------------------------------------
Expand Down
3 changes: 2 additions & 1 deletion phpbench.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"$schema":"vendor-bin/phpbench/vendor/phpbench/phpbench/phpbench.schema.json",
"runner.bootstrap": "vendor/autoload.php",
"runner.file_pattern": "*Bench.php"
"runner.file_pattern": "*Bench.php",
"storage.xml_storage_path": "dist/bench"
}