Skip to content

Fix typos in phar-signing.md #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theofidry merged 1 commit into from
Apr 23, 2026
+2 −2
Merged

Fix typos in phar-signing.md #1622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/phar-signing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ of the archive does not match the signature of the PHAR and will bail out.

### Why it is bad

There is a few downsides from this signing mechanisms:
There are a few downsides to this signing mechanism:

- You cannot run the PHAR without its associated public key file laying right next to it. As a result, if you were to
move your PHAR under `/usr/local/bin`, the PHAR would no longer work due to the missing public key file.
Expand Down Expand Up @@ -338,7 +338,7 @@ jobs:
run: ...

# Smoke test.
# It is recommended ot have some sorts of tests for your PHAR.
# It is recommended to have some sorts of tests for your PHAR.
- name: Ensure the PHAR works
run: bin/command.phar --version

Expand Down
Loading