Skip to content

feat(threaded-replies): hide reply#3447

Open
TylerGauntlett wants to merge 2 commits intobox:masterfrom
TylerGauntlett:hide-reply
Open

feat(threaded-replies): hide reply#3447
TylerGauntlett wants to merge 2 commits intobox:masterfrom
TylerGauntlett:hide-reply

Conversation

@TylerGauntlett
Copy link
Collaborator

@TylerGauntlett TylerGauntlett commented Oct 18, 2023

What this does

  • Hides the "Reply" button when the comment is in a resolved state
  • Visually maintains margins/padding when "Reply" button is displayed

Callouts

  • Margins had to be changed around a bit to properly apply bottom margin when the "Reply" button is shown vs hidden

Demo

Screenshot 2023-10-18 at 2 05 40 pm

@TylerGauntlett TylerGauntlett requested a review from a team as a code owner October 18, 2023 18:05
@TylerGauntlett TylerGauntlett changed the title Hide reply feat(threaded-replies): hide reply Oct 18, 2023
Copy link
Contributor

@mickr mickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants