chore(lint): add linting and formatting to CI#3816
chore(lint): add linting and formatting to CI#3816greg-in-a-box wants to merge 3 commits intobox:masterfrom
Conversation
a53a2f2 to
9a7b4a3
Compare
9a7b4a3 to
da303b0
Compare
da303b0 to
e3e1e47
Compare
tjuanitas
left a comment
There was a problem hiding this comment.
i think we might want to differentiate between linting and formatting. im looking into if it's possible to run the lint-staged config against modified files in a PR. that seems like an easiest approach without having to keep these script files in sync
| - setup-workspace | ||
| - run: | ||
| name: Typescript | ||
| command: yarn --cwd /buie tsc |
There was a problem hiding this comment.
not sure if this is intended and related to the caching issue from a few weeks ago but the working directory defined at the top is ~/buie while all of these are commands occur at /buie
There was a problem hiding this comment.
its intentional, I tried different combinations to get it to match without having to hardcode the working directory folder, this was the only combination that worked.
There was a problem hiding this comment.
aren't these referring to separate directories though?
I think the bigger issue is using the lint-staged commands via CI, since you can just |
No description provided.