Skip to content

fix: USM text input not taking up full width#4435

Merged
mergify[bot] merged 2 commits intobox:masterfrom
kduncanhsu:fix/text-input-width-usm
Feb 4, 2026
Merged

fix: USM text input not taking up full width#4435
mergify[bot] merged 2 commits intobox:masterfrom
kduncanhsu:fix/text-input-width-usm

Conversation

@kduncanhsu
Copy link
Contributor

@kduncanhsu kduncanhsu commented Feb 3, 2026

Manual QA reported a bug on staging where the UnifiedShareModal was being rendered incorrectly in EUA.

This PR fixes that by adding width: 100% to the Tooltip wrappers which are rendered in EmailForm

BEFORE

Screenshot 2026-02-03 at 4 30 04 PM

AFTER

Screenshot 2026-02-03 at 3 44 19 PM

Summary by CodeRabbit

  • Style
    • Refined email sharing form styling: tooltip target now spans full width for improved layout and visual consistency; minor CSS/class scoping updates to stabilize presentation across contexts. No changes to functionality or public interfaces.

@kduncanhsu kduncanhsu requested a review from a team as a code owner February 3, 2026 23:47
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

Walkthrough

Adds a stylesheet import and a scoped className to the EmailForm component, introduces a CSS rule targeting tooltip elements under .bdl-EmailForm, and consolidates several object destructurings in component methods (stylistic refactors only).

Changes

Cohort / File(s) Summary
EmailForm component
src/features/unified-share-modal/EmailForm.js
Imported EmailForm.scss; injected bdl-EmailForm into component classNames; condensed destructuring in componentDidUpdate and validateContactsRestrictions (no behavioral changes).
EmailForm styles
src/features/unified-share-modal/EmailForm.scss
Added rule targeting .bdl-EmailForm .bdl-Tooltip-target to set width: 100% for tooltip targets.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

ready-to-merge

Suggested reviewers

  • tjiang-box
  • tjuanitas

Poem

🐰 A patch with sass and tidy lines,
I hopped through code and straightened signs.
Tooltips stretch to fit the frame,
Destructured bits — still runs the same. 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fixing a USM text input width issue to be full width, which directly corresponds to the changes in EmailForm component and styling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed PR description includes context, problem statement, and visual evidence via before/after screenshots demonstrating the fix.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify mergify bot added the queued label Feb 4, 2026
@mergify mergify bot merged commit 7036b71 into box:master Feb 4, 2026
11 of 12 checks passed
@mergify
Copy link
Contributor

mergify bot commented Feb 4, 2026

Merge Queue Status

✅ The pull request has been merged at 3febc38

This pull request spent 4 seconds in the queue, with no time running CI.
The checks were run in-place.

Required conditions to merge

@mergify mergify bot removed the queued label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants