Skip to content

fix: internal select container not taking up full width#4436

Closed
Lindar90 wants to merge 1 commit intobox:masterfrom
Lindar90:select-tooltip-fix
Closed

fix: internal select container not taking up full width#4436
Lindar90 wants to merge 1 commit intobox:masterfrom
Lindar90:select-tooltip-fix

Conversation

@Lindar90
Copy link

@Lindar90 Lindar90 commented Feb 4, 2026

This PR fixes that by adding width: 100% to the Tooltip wrappers which are rendered inside of Select internal container

Before:
image

After:
image

Summary by CodeRabbit

  • Style
    • Improved tooltip display width in the select component.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Denis Marusevich seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

Walkthrough

This change adds a CSS rule to the Select component's stylesheet that ensures tooltip targets span the full width of their container by setting .bdl-Tooltip-target { width: 100% }.

Changes

Cohort / File(s) Summary
Select Component Styling
src/components/select/Select.scss
Adds .bdl-Tooltip-target { width: 100% } CSS rule to make tooltip targets fill the full container width.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • PR #4435: Applies the same .bdl-Tooltip-target { width: 100% } CSS rule to a different component SCSS file to fix tooltip/input width alignment.

Suggested reviewers

  • tjiang-box
  • JChan106
  • tjuanitas

Poem

🐰 A tooltip that stretches with grace,
One hundred percent fills the space,
The Select now shines, so wide and free,
Width full—just as it should be! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description explains the fix, provides before/after screenshots, but lacks substantive detail about the change itself. Consider adding more context: what component was affected, why the fix was needed, and technical details about the CSS change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding CSS to make the internal select container take up full width.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Lindar90 Lindar90 marked this pull request as ready for review February 4, 2026 13:10
@Lindar90 Lindar90 requested a review from a team as a code owner February 4, 2026 13:10
@Lindar90 Lindar90 marked this pull request as draft February 4, 2026 13:25
@Lindar90 Lindar90 closed this Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants