Credstore POC#1
Open
boyan-velinov wants to merge 4 commits into
Open
Conversation
boyan-velinov
force-pushed
the
credstore2
branch
from
c22f738 to
a964ce7
Compare
boyan-velinov
force-pushed
the
credstore2
branch
9 times, most recently
from
60ae6ff to
2e1f962
Compare
Configuration entries with spaceId equals to NULL are entries for deleted spaces. Such entries are stored long time ago and when we created data termination service they were not migrated, since spaceid was not found for the combination of org_name and space_name. Jira: LMCROSSITXSADEPLOY-729
The existing logic relies on combination of org and space names. space and org name can be changed in time in such case entries remained as leftovers in configuration registry. The new logic relies on spaceId because it is unique. Jira: LMCROSSITXSADEPLOY-729
The step seems not useful because it deletes entries only for the existing application that were created from last deployed MTA with that exact version. Other step DeleteDiscontinuedConfigurationEntriesStep should cover that scenario as well - it deletes all entries that are not published by currend operation. Jira: LMCROSSITXSADEPLOY-729
boyan-velinov
force-pushed
the
credstore2
branch
from
2e1f962 to
7b11eb0
Compare
|
SonarCloud Quality Gate failed.
|
boyan-velinov
force-pushed
the
master
branch
3 times, most recently
from
9fde6b8 to
d678865
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Issue: