Skip to content

Unit conversions sketch#359

Draft
jonnyh404 wants to merge 2 commits intomasterfrom
unit_conversions_sketch
Draft

Unit conversions sketch#359
jonnyh404 wants to merge 2 commits intomasterfrom
unit_conversions_sketch

Conversation

@jonnyh404
Copy link
Collaborator

Starts a template for implementation of unit conversions.

Exact pulls of the unit conversions values will ideally be pulled from a repository/module rather than hard coded constants.

@codecov
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 82.22222% with 8 lines in your changes missing coverage. Please review.

Project coverage is 93.36%. Comparing base (c1eb818) to head (c19d5ca).
Report is 3 commits behind head on master.

Files Patch % Lines
ResSimpy/Units/Units.py 58.33% 5 Missing ⚠️
ResSimpy/Units/convert_units.py 90.90% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
- Coverage   93.42%   93.36%   -0.06%     
==========================================
  Files         169      171       +2     
  Lines       12099    12155      +56     
==========================================
+ Hits        11303    11349      +46     
- Misses        796      806      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonnyh404 jonnyh404 self-assigned this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant