Skip to content

Write procs#514

Open
jonnyh404 wants to merge 10 commits intomasterfrom
write_procs
Open

Write procs#514
jonnyh404 wants to merge 10 commits intomasterfrom
write_procs

Conversation

@jonnyh404
Copy link
Collaborator

Adds the procs writing to the model file generation.

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.12%. Comparing base (10795ac) to head (f22a679).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
ResSimpy/Nexus/DataModels/Network/NexusProc.py 91.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #514   +/-   ##
=======================================
  Coverage   93.12%   93.12%           
=======================================
  Files         215      215           
  Lines       16283    16317   +34     
=======================================
+ Hits        15163    15195   +32     
- Misses       1120     1122    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@yzaparb yzaparb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

all_nodes = self.model.network.nodes.get_all()
all_connections = self.model.network.connections.get_all()
all_activations = self.model.network.activation_changes.get_all()
all_proces = self.model.network.procs.get_all()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to use proces? or procs?

Copy link
Collaborator

@cflynn3 cflynn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a coding perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants