Feedback support#4
Open
jeremytregunna wants to merge 110 commits intobpoweski:masterfrom
jeremytregunna:master
Open
Feedback support#4jeremytregunna wants to merge 110 commits intobpoweski:masterfrom jeremytregunna:master
jeremytregunna wants to merge 110 commits intobpoweski:masterfrom
jeremytregunna:master
Conversation
feedback client now implemented
…o added missing requires.
…pected to be a string. This will be handy for us when we go to hook apnserver into cassandra, where the certificate will be retreived as a string.
…path. Behaviour changed internally to take a string instead, so we pass it a string reading it from a file.
…et back from the service, not actually acting on them.
…feedback data. Suitable for primetime!
…d confusion, and cleaned up a bit of nonsense (wrong urls, etc).
… like long opened sockets.
…ine as well as i thought i guess
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've implemented feedback support, and if you want you can pull from my fork.
One note to make, I did change the README.textile so anyone in one of the commits so folks stumbling on my fork would know that it's not the original. You won't want to apply that, but I didn't separate it into its own commit unfortunately. As such, you'll want to selectively apply this commit 3fb6edc which contains those changes.
In that modification I also do assert copyright as well, but only over the code I've written, and I've released it under the same license you're using, MIT.
If you have questions, let me know.