Skip to content

Add mobile responsiveness #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bprosen merged 2 commits into from
Dec 29, 2025
Merged

Add mobile responsiveness #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1fb3f9
mobile responsiveness
bprosen Dec 29, 2025
6915b43
biome
bprosen Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/components/UnderConstruction/UnderConstruction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,19 @@ import { Card, CardContent, CardHeader, CardTitle } from '~/ui';

export const UnderConstruction: React.FC = () => {
return (
<Card className='shadow-xl'>
<Card className='shadow-xl md:max-w-xl my-4 mx-12 sm:mx-4 md:mx-auto'>

@coderabbitai coderabbitai Bot Dec 29, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Horizontal margin too large for mobile screens.

The margin progression mx-12 sm:mx-4 md:mx-auto applies 48px horizontal margin (96px total) on screens below 640px. On small mobile devices (320px–414px), this leaves minimal space for card content and can severely impact readability or cause overflow.

For mobile responsiveness, the base (smallest screen) should have the smallest margin, then scale up.

🔎 Proposed fix 
-    <Card className='shadow-xl md:max-w-xl my-4 mx-12 sm:mx-4 md:mx-auto'>
+    <Card className='shadow-xl md:max-w-xl my-4 mx-4 sm:mx-8 md:mx-auto'>

This provides a mobile-first progression: 16px (mobile) → 32px (small) → centered (medium+).

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<Card className='shadow-xl md:max-w-xl my-4 mx-12 sm:mx-4 md:mx-auto'>
<Card className='shadow-xl md:max-w-xl my-4 mx-4 sm:mx-8 md:mx-auto'>
🤖 Prompt for AI Agents 
In src/components/UnderConstruction/UnderConstruction.tsx around line 6, the
Card uses a large base horizontal margin ('mx-12 sm:mx-4 md:mx-auto') which
creates excessive spacing on very small screens; change the utility classes to a
mobile-first progression such as 'mx-4 sm:mx-8 md:mx-auto' so the base (mobile)
margin is 16px, small screens get 32px, and medium+ screens remain centered.

<CardHeader>
<CardTitle className='text-center text-3xl'>
<CardTitle className='text-center text-2xl sm:text-3xl'>
Hold on a second!
</CardTitle>
</CardHeader>
<CardContent className='flex flex-col items-center gap-4'>
<Construction color='#e4ec75' size={350} strokeWidth={1.2} />
<p className='text-lg'>
<Construction
className='w-[200px] h-[200px] sm:w-[250px] sm:h-[250px] md:w-[350px] md:h-[350px]'
color='#e4ec75'
strokeWidth={1.2}
/>
<p className='text-base sm:text-lg text-center'>
This page is under construction, check back soon
</p>
</CardContent>
Expand Down