Syncing from upstream OCA/e-commerce (19.0)#936
Merged
Conversation
ADD website_sale_charge_payment_fee_delivery: link module ADD website_sale_charge_payment_fee_quote: link module
…o acquirer If there are no acquirers, gets ``` Error to render compiling AST TypeError: 'NoneType' object has no attribute '__getitem__' Template: 929 Path: /templates/t/t/div/div[1]/div/div[2]/input Node: <input type="hidden" t-att-value="selected_acquirer.id if selected_acquirer else acquirers[0].id" name="selected_acquirer_id" data-oe-id="1278" data-oe-xpath="/data/xpath[3]/input" data-oe-model="ir.ui.view" data-oe-field="arch"/> ```
…re is no acquirer
We avoid this way the warning on runbot and it's more tolerant to inheritance.
Currently translated at 100.0% (21 of 21 strings) Translation: e-commerce-14.0/e-commerce-14.0-website_sale_charge_payment_fee Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_charge_payment_fee/es/
- Bump module version to 19.0.1.0.0 - Adapt payment form JavaScript to the new PaymentForm interaction patching API - Use request.cart and updated website_sale payment flow helpers - Add support for applying payment fees during express checkout - Adapt payment transaction fee update to the 19.0 payment portal flow - Update sale order fee computation for tax-included and tax-excluded website totals - Replace renamed sale order line fields and dependencies for 19.0 - Hide payment fee lines from the cart line display - Update website sale total template xpath - Remove obsolete roadmap entry about express checkout support
Without this patch, it's easy that the tour fails randomly due to a timeout when generating the sales order report. These assets can take a long time, increasing when more addons are installed.
In an integrated database, this patch makes the test go from this log:
2020-11-06 10:34:53,941 34 INFO devel werkzeug: 127.0.0.1 - - [06/Nov/2020 10:34:53] "POST /payment/transfer/feedback HTTP/1.1" 302 - 730 4.368 11.800
To this one:
2020-11-06 10:32:55,517 34 INFO devel werkzeug: 127.0.0.1 - - [06/Nov/2020 10:32:55] "POST /payment/transfer/feedback HTTP/1.1" 302 - 479 2.906 5.771
That's about 50% the time.
In the same patch, I remove the `self.env` patch that was only needed for Odoo v11 and lower.
With the old tour, timeout problems started to occur, even with 7830084 This partially reverts that, and instead uses a simpler tour to test the creation of the SO. TT26399
If we don't trigger the onchanges, we won't get some of the default values that the order type has defined TT30235
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-16.0/e-commerce-16.0-website_sale_order_type Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_order_type/
Currently translated at 100.0% (1 of 1 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_order_type Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_order_type/es/
When using the demo product "Customizable Desk" in the standard behaviour there is an intermediate step in which the variant of the product to be added to the cart is chosen. This step may not be there if there are no variants really because some module has modified this and to avoid errors in the tests it is better to create a product in which we are sure that there are no variants and the step of selecting the variant before adding to the cart does not exist.
Currently translated at 100.0% (1 of 1 strings) Translation: e-commerce-18.0/e-commerce-18.0-website_sale_order_type Translate-URL: https://translation.odoo-community.org/projects/e-commerce-18-0/e-commerce-18-0-website_sale_order_type/es/
Currently translated at 0.0% (0 of 1 strings) Translation: e-commerce-18.0/e-commerce-18.0-website_sale_order_type Translate-URL: https://translation.odoo-community.org/projects/e-commerce-18-0/e-commerce-18-0-website_sale_order_type/pt_BR/
Currently translated at 0.0% (0 of 1 strings) Translation: e-commerce-18.0/e-commerce-18.0-website_sale_order_type Translate-URL: https://translation.odoo-community.org/projects/e-commerce-18-0/e-commerce-18-0-website_sale_order_type/ca/
Currently translated at 100.0% (1 of 1 strings) Translation: e-commerce-18.0/e-commerce-18.0-website_sale_order_type Translate-URL: https://translation.odoo-community.org/projects/e-commerce-18-0/e-commerce-18-0-website_sale_order_type/it/
…rt when skip payment
Currently translated at 100.0% (3 of 3 strings) Translation: e-commerce-19.0/e-commerce-19.0-website_sale_stock_picking_policy Translate-URL: https://translation.odoo-community.org/projects/e-commerce-19-0/e-commerce-19-0-website_sale_stock_picking_policy/it/
Currently translated at 100.0% (8 of 8 strings) Translation: e-commerce-19.0/e-commerce-19.0-website_sale_product_reference_displayed Translate-URL: https://translation.odoo-community.org/projects/e-commerce-19-0/e-commerce-19-0-website_sale_product_reference_displayed/it/
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 19.0 #936 +/- ##
==========================================
+ Coverage 94.82% 95.16% +0.34%
==========================================
Files 61 75 +14
Lines 946 1302 +356
Branches 77 107 +30
==========================================
+ Hits 897 1239 +342
- Misses 36 42 +6
- Partials 13 21 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bt_gitbot