Syncing from upstream OCA/edi-framework (19.0)#164
Merged
Conversation
Currently translated at 100.0% (286 of 286 strings) Translation: edi-framework-19.0/edi-framework-19.0-edi_core_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-19-0/edi-framework-19-0-edi_core_oca/it/
Currently translated at 100.0% (56 of 56 strings) Translation: edi-framework-19.0/edi-framework-19.0-edi_endpoint_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-19-0/edi-framework-19-0-edi_endpoint_oca/it/
When using edi_notification_oca, EDI exchanges that failed during send,
receive, or validation did not trigger any notification, leaving errors
unnoticed and requiring manual detection.
The backend only emitted "on_edi_exchange_error" on the process error
path. Other error paths updated the state and posted chatter messages
but did not fire the event.
This change ensures the error event is emitted on all error transitions:
exchange_send -> _notify_error("send_ko")
exchange_receive -> _notify_error("receive_ko", "validate_ko")
exchange_generate -> _notify_error("validate_ko")
Calls are guarded by state changes to avoid duplicate notifications.
Redundant chatter messages are removed since _notify_error already
handles logging and event emission.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 19.0 #164 +/- ##
==========================================
+ Coverage 84.91% 85.32% +0.41%
==========================================
Files 107 112 +5
Lines 4321 4449 +128
Branches 272 279 +7
==========================================
+ Hits 3669 3796 +127
Misses 576 576
- Partials 76 77 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bt_gitbot