Skip to content

Use qt-niu display_warning for atlas download/update confirmation#235

Open
Ankithg21 wants to merge 2 commits into
brainglobe:mainfrom
Ankithg21:issue-154-use-qt-niu-dialog
Open

Use qt-niu display_warning for atlas download/update confirmation#235
Ankithg21 wants to merge 2 commits into
brainglobe:mainfrom
Ankithg21:issue-154-use-qt-niu-dialog

Conversation

@Ankithg21
Copy link
Copy Markdown

@Ankithg21 Ankithg21 commented Feb 19, 2026

Description

This PR addresses Issue #154 by replacing custom atlas download/update confirmation dialogs with the display_warning dialog from qt-niu, as recommended.

Previously, confirmation dialogs were implemented manually, which resulted in inconsistent UI behavior compared to other BrainGlobe tools.

This update standardizes the dialog handling by using the qt-niu utility, ensuring consistency across the BrainGlobe ecosystem.

References

Closes #154

How has this PR been tested?

  • Tested locally after implementing the changes
  • Verified that atlas download and update confirmation dialogs appear correctly
  • Confirmed that user interaction (accept/cancel) works as expected
  • Ensured no regression in atlas loading functionality

Is this a breaking change?

No. This PR does not introduce any breaking changes.

Does this PR require an update to the documentation?

No documentation update is required, as this change improves internal UI consistency without altering user-facing functionality.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Comment thread pyproject.toml Outdated
"meshio",
"napari>=0.6.1",
"numpy",
"qt-niu @ git+https://github.com/neuroinformatics-unit/qt-niu.git@1688dcae6d14ee460e5ca9bb4d1b432dc173e52c",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on PyPI, it doesn't need to be installed from GitHub

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out! I've updated the dependency to install qt-niu from PyPI instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use UI dialogs from brainglobe-utils

2 participants