Use qt-niu display_warning for atlas download/update confirmation#235
Open
Ankithg21 wants to merge 2 commits into
Open
Use qt-niu display_warning for atlas download/update confirmation#235Ankithg21 wants to merge 2 commits into
Ankithg21 wants to merge 2 commits into
Conversation
adamltyson
reviewed
Feb 19, 2026
| "meshio", | ||
| "napari>=0.6.1", | ||
| "numpy", | ||
| "qt-niu @ git+https://github.com/neuroinformatics-unit/qt-niu.git@1688dcae6d14ee460e5ca9bb4d1b432dc173e52c", |
Member
There was a problem hiding this comment.
This is on PyPI, it doesn't need to be installed from GitHub
Author
There was a problem hiding this comment.
Thanks for pointing that out! I've updated the dependency to install qt-niu from PyPI instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses Issue #154 by replacing custom atlas download/update confirmation dialogs with the
display_warningdialog fromqt-niu, as recommended.Previously, confirmation dialogs were implemented manually, which resulted in inconsistent UI behavior compared to other BrainGlobe tools.
This update standardizes the dialog handling by using the
qt-niuutility, ensuring consistency across the BrainGlobe ecosystem.References
Closes #154
How has this PR been tested?
Is this a breaking change?
No. This PR does not introduce any breaking changes.
Does this PR require an update to the documentation?
No documentation update is required, as this change improves internal UI consistency without altering user-facing functionality.
Checklist: