Fix tooltip text color for napari#240
Open
Arbaaz123676 wants to merge 1 commit into
Open
Conversation
Author
|
Hi! @TimMonko @adamltyson I’ve opened a PR that removes the hardcoded tooltip text colour so it correctly adapts to napari’s theme. Please let me know if any changes are needed. Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
- Coverage 97.03% 97.02% -0.01%
==========================================
Files 14 14
Lines 640 639 -1
==========================================
- Hits 621 620 -1
Misses 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue where cursor tooltip text appears as dark text on a dark background in napari dark mode.
The problem was caused by a hardcoded stylesheet:
This prevented Qt/napari from adapting the tooltip text color according to the active theme.
Changes
Removed the hardcoded tooltip text color.
Result
Tooltips now correctly adapt to dark mode.
Fixes #215