Fix ANR in VideoPlaybackService by removing blocking loadBitmap - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry issues REACT-NATIVE-MY (64 events, 15 users) and REACT-NATIVE-HE (37 events, 9 users) show the main thread blocked at:
buildNotification()callsloadBitmap(uri).get()to set the large artwork icon on the media notification. Thisblocks the main thread while waiting for the bitmap to load from disk or network. If it takes too long, Android calls ANR.
The fix removes the blocking
.get()call. The notification still shows title, description, playback controls, and thesmall icon in the status bar — just without the large artwork image visible when the notification is expanded. He Android
13+ this code path was never used anyway, since artwork is handled automatically via MediaStyle.