More explicit default git settings#1972
Open
Ankur Goyal (ankrgyl) wants to merge 3 commits into
Open
Conversation
Ankur Goyal (ankrgyl)
changed the title
Contributor
Manu Goyal (manugoyal)
left a comment
Manu Goyal (manugoyal)
left a comment
There was a problem hiding this comment.
Wondering if we really need the defaults in the SDK level too? Same applies to the python sdk
| state.proxyUrl = iso.getEnv("BRAINTRUST_PROXY_URL") ?? org.proxy_url; | ||
| state.gitMetadataSettings = org.git_metadata || undefined; | ||
| state.gitMetadataSettings = | ||
| org.git_metadata || defaultGitMetadataSettings(); |
Contributor
There was a problem hiding this comment.
Do we really need to default these settings in both the SDKs and the control
plane? I worry about maintining duplicate copies of defaults across our control
plane and SDKs in case we want to revise this.
If we are always defaulting in the control plane now, maybe we can defensively
switch this to not collecting anything if the apikey/login endpoint returns
nothing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.