Skip to content

chore: Allow for nox commands to be passed down #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into from
Mar 9, 2026
+4 −2
Merged

chore: Allow for nox commands to be passed down #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions py/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
SILENT_INSTALLS = True
LATEST = "latest"
ERROR_CODES = tuple(range(1, 256))
INTERNAL_TEST_FLAGS = {"--wheel", "--disable-vcr"}


# The minimal set of dependencies we need to run tests.
Expand Down Expand Up @@ -387,6 +388,7 @@ def _run_tests(session, test_path, ignore_path="", ignore_paths=None, env=None):
env = env.copy() if env else {}
wheel_flag = "--wheel" in session.posargs
common_args = ["--disable-vcr"] if "--disable-vcr" in session.posargs else []
pytest_posargs = [arg for arg in session.posargs if arg not in INTERNAL_TEST_FLAGS]

# Support both ignore_path (for backward compatibility) and ignore_paths
paths_to_ignore = []
Expand All @@ -408,7 +410,7 @@ def _run_tests(session, test_path, ignore_path="", ignore_paths=None, env=None):
]
for path in paths_to_ignore:
test_args.append(f"--ignore=src/{path}")
session.run(*test_args, *common_args, env=env)
session.run(*test_args, *common_args, *pytest_posargs, env=env)
return

# Running the tests from the wheel involves a bit of gymnastics to ensure we don't import
Expand All @@ -431,7 +433,7 @@ def _run_tests(session, test_path, ignore_path="", ignore_paths=None, env=None):
# It proved very helpful because it's very easy
# to accidentally import local modules from the source directory.
env["BRAINTRUST_TESTING_WHEEL"] = "1"
session.run(pytest_path, abs_test_path, *ignore_args, *common_args, env=env)
session.run(pytest_path, abs_test_path, *ignore_args, *common_args, *pytest_posargs, env=env)

# And a final note ... if it's not clear from above, we include test files in our wheel, which
# is perhaps not ideal?
Expand Down