Brighten green subtitle text - #72
Merged
Merged
Conversation
Styled subtitles mapped the "green" colour class to HTML's dim #008000, and the appearance editor's Green preset was a washed-out pastel. Both read poorly over the semi-transparent caption background next to the other, fully saturated caption colours. Both now use one bright broadcast (CEA-608) caption green, #00FF00, defined once as SubtitleColor.green so the preview, the preset and markup-coloured cues always match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
brandomoore
requested changes
Sep 28, 2026
brandomoore
left a comment
brandomoore
left a comment
Owner
There was a problem hiding this comment.
The brighter Green option in Plozz's settings is a good improvement. Could we keep that change but leave the subtitle-file color mappings alone? In SRT/HTML, <font color=green> means #008000, while WebVTT's lime already renders as #00FF00. Mapping both to the Green preset changes a show's chosen subtitle colors even for people who never select Green. Please keep the existing green/lime mappings in SubtitleMarkup and test them separately instead of requiring markup green to match the preset. The hosted CI failure is in NativeSubtitlePresentationTests' same-language HLS switching test, not a color test; we'll recheck CI after the revision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Green subtitle text was dull and hard to read on the semi-transparent caption background. The Green preset and markup green (WebVTT/SRT, e.g. broadcast captions) now both use the bright CEA-608 caption green #00FF00, defined once as SubtitleColor.green, so the preview and the actual subtitles match.