Fix: Delta updates on non-English systems failed - #31
Merged
Conversation
The failure message in `log stream` was:
Error: During delta extraction Error Domain=NSCocoaErrorDomain
Code=256 "Source doesn't have expected hash (... != ...).
The reason was that Sparkle uses a hash before delta update application
to check whether the (old) destination contents are as expected. This
hash calculation was locale-dependent.
This is the same as upstream's 8edc77f.
6 tasks
There was a problem hiding this comment.
Pull request overview
Fixes delta update verification failures on non-English systems by making the file-sorting comparator used during tree hashing locale-independent, ensuring consistent hash computation across different user locales.
Changes:
- Use the C locale explicitly for filename collation during FTS traversal.
- Add the required locale header to access locale-specific collation APIs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure message in
log streamwas:The reason was that Sparkle uses a hash before delta update application to check whether the (old) destination contents are as expected. This hash calculation was locale-dependent.
This is the same as upstream's 8edc77f.
I believe the risk of this change is manageable because 1. upstream uses the same code and 2. as far as I have seen, it is only used for delta updates. In the worst case, we could fall back to shipping full updates only.