-
Notifications
You must be signed in to change notification settings - Fork 0
fix(skills): macOS verification routing and foundation entry point #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d6bb593
fix(skills): fix macOS verification routing and strengthen foundation…
brbndon 0cc2477
docs(skills): route new-app entry points through foundation
brbndon 7026f77
docs(skills): align workflow entry paths with foundation router
brbndon bef377a
fix(skills): platform-branch consumer AGENTS and bootstrap fixtures
brbndon 84d9cc8
fix(skills): require macOS compile when tests are absent
brbndon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
...s/skills/apple-development-foundation/references/competing-macos-skills-plan.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # Competing macOS skills — routing plan | ||
|
|
||
| Goal: keep `$apple-development-foundation` the **global entry point** for new | ||
| macOS (and iOS) SwiftUI bootstrap and foundation-routed Apple work, while | ||
| leaving specialized non-foundation skills for their own niches. | ||
|
|
||
| ## Problem | ||
|
|
||
| Hosts often also install generic skills such as `macos-development`, | ||
| `macos-app-design`, `macos-design-guidelines`, or platform design packs. A vague | ||
| prompt like “build a new macOS app” can activate those first and skip this | ||
| catalog’s bootstrap → design-system → verification chain. | ||
|
|
||
| ## Decision | ||
|
|
||
| | Request shape | Route first | Then | | ||
| | --- | --- | --- | | ||
| | New iOS/macOS SwiftUI app or major app skeleton | `$apple-development-foundation` → `$codex-bootstrap` | Chained foundation children | | ||
| | Feature planning (no implement) | `$apple-development-foundation` → `$apple-platform-planner` | Review skills only if asked | | ||
| | Ordinary feature/component in an existing consumer app | Child skill directly (`swiftui-component-author`, …) | `$swift-testing-verification` | | ||
| | Pure HIG / visual critique with no foundation workflow | External design skill is fine | Do not invent bootstrap | | ||
| | Foundation skill inventory / installer audit | `$apple-development-foundation` (audit path) | Foundation verify scripts only | | ||
|
|
||
| ## Description / discovery levers (done or next) | ||
|
|
||
| 1. **Done in this change:** Strengthen the master skill `description` so bootstrap | ||
| and “new app” language matches first; state preference over generic macOS/iOS | ||
| skills; keep exclusions (no implied audit, no replacing children). | ||
| 2. **Next (host install):** Ensure `$apple-development-foundation` and | ||
| `$codex-bootstrap` are installed in the active host skill scope | ||
| (`./Scripts/install-skills.sh` for Codex). Cursor/Claude manual installs | ||
| should symlink the same skill directories. | ||
| 3. **Next (optional AGENTS / user rule):** One always-on line in consumer or | ||
| user guidance: “For new Apple apps or foundation workflows, invoke | ||
| `$apple-development-foundation` before generic macOS skills.” | ||
| 4. **Avoid:** Renaming or deleting useful external skills. Prefer routing | ||
| precedence, not a monoculture. | ||
|
|
||
| ## Evaluation coverage | ||
|
|
||
| Add/keep fixtures where “new macOS SwiftUI app” / “bootstrap with the foundation” | ||
| expect `apple-development-foundation` then `codex-bootstrap`, not planner-only | ||
| and not archive work. | ||
|
|
||
| ## Success criteria | ||
|
|
||
| - Explicit `$apple-development-foundation` + new-app prompt shortlists | ||
| `codex-bootstrap` without scanning or auditing. | ||
| - Vague new-app prompts that mention the foundation (or are under foundation | ||
| user rules) do not prefer generic `macos-development` over this catalog. | ||
| - Design-only or HIG-only prompts can still use external design skills. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a macOS-only bootstrap creates the recommended consumer guidance,
assets/consumer-AGENTS.md.template:95-115still mandates simulator management, an exactsimulatorId,build_run_sim, andtest_sim. That scopedAGENTS.mdthen governs future work in the consumer repository and conflicts with this new macOS branch, directing agents to iOS-only tools instead ofbuild_run_macosandtest_macos; branch the generated guidance by platform as part of this change.Useful? React with 👍 / 👎.