fix bitmap plot screen location#148
Open
stevesims wants to merge 2 commits intobreakintoprogram:mainfrom
Open
Conversation
the bitmap plot code was always plotting based on the top-left corner of the bitmap. when using OS coordinates this is incorrect behaviour - plot location should be based on the bottom-left corner, as per Acorn GXR this fixes that behaviour
fixes issue with capturing bitmap to buffer zero (the `createBuffer` call was preventing creation of buffer with ID 0, as it can’t be used as a place to redirect output) fixes recently introduced bug with behaviour of VDU 23,27,3 caused by changes to drawBitmap which was compensating for the height of the bitmap when it should only do that for plot calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the recently added bitmap plot code was always plotting based on the top-left corner of the bitmap. when using OS coordinates this is incorrect behaviour - plot location should be based on the bottom-left corner, as per Acorn GXR
this fixes that behaviour