Open
Conversation
Owner
|
Thanks for this :) If we go ahead and document this then it might be better to store the bulk of the information in a wiki page (I can turn this on), or in a show and tell: https://github.com/brendon/positioning/discussions/categories/show-and-tell. We can link to it from the README. That way it can be updated in the future easily and people can comment on it etc... In saying that, if it's just a matter of having positioning being aware of the discard gem and listening to the right callbacks then perhaps we could add that as a feature instead? Would it be as simple as responding to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use discard gem, and after reading several issues/discussions in this repo we found it wasn't enough for us so we wrote a simple initializer which improves interoperability with the discard gem. The changes should be self explanatory.