chore: state plugin rules without history or tracker references - #372
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aaf56ea64f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 2 of 3 from the prompt-cruft audit.
Prose scrub (no rule changed). Plugin runtime prose now states each rule in present tense. Issue and PR numbers are gone, as is framing that diffs against earlier versions ("no longer", "today's serial behavior", "as before", "now applies", "SUPERSEDES the prior…", "What changed from
manifest_version: 3"). Covered files:agents/overlord.mdgovernance/remediation-doctrine.mdreferences/run-ledger-schema.md: the shared "additive, free-form, no schema change" invariant is now stated once instead of four times.references/brood-ledger-model.mdreferences/github-pr-review-graphql.mdgithub-review-loop,spawn-brood,record-state-result,next-wavestandard-delivery,pr-feedback-remediationCLAUDE.mdLocal Codex review found no meaning-preservation issue in any rewrite.
Regression guard (CHECK 15).
tools/policy_check.shnow fails on bare tracker references (#123) inplugin/**/*.mdandplugin/workflows/*.json, so issue numbers cannot creep back.owner/repo#Ncitations are exempt.tests/policy/fixtures/tracker-ref-*.md. One fixture has an unclosed frontmatter opener, to prove no region is ever skipped.tests/policy/safety-tracker-ref-guard.jsonpins the check and its scanner canary.Known limitations (accepted, tracked)
Local review found two latent false negatives in CHECK 15. Neither affects current content: the check reports 0 findings on
plugin/.issue#123orPR#456are exempt, because theowner/repo#Nexemption is too broad.The fix changes the detection approach from a reject list to a safe-shape allowlist, and adds checked reads. It is tracked in #371 instead of being patched here. Separately, CHECK 15 allowlist entries are line-granular (shared allowlist machinery). This is recorded in the check's comments; there are no CHECK 15 allowlist entries.
Validation
bash tools/validate.sh --changed, which escalates to the full suite becausetools/**changed: 23 suites pass, 0 new policy findings, and Check 15 passes on 64 files.#999 #1000in plugin prose, re-adding a frontmatter skip, re-adding first-token-only emission, and a wrong hex-colour trailing class.Versioning
PATCH 4.0.1 -> 4.0.2.
CHANGELOG.mdhas a[4.0.2]entry with Added (CHECK 15) and Changed (prose scrub) sections.Unresolved issues