Repository navigation
docs(adr): date ADR-0019 brood-manifest literals as snapshots (#375) - #380
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 51e46a4d50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex P2: the new amendment named ADR-0021 as the live owner of the manifest reader mechanism, but ADR-0021 is itself append-only and dated and its reader-mechanism section is stale, so readers were sent to two mutually exclusive current contracts. Removes ADR-0021 from every live-source pointer this amendment adds and states the eliminated class in item 3: no ADR is ever named as a live source, because an ADR is append-only and dated and its content is a snapshot by this amendment's own standing rule. A live source is a maintained document edited in place when the thing it describes changes. No live value is added; all pointers stay pointer-form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #375.
ADR-0019's 2026-06-01 brood-manifest amendment ("JSON manifest root fix") still states two facts that no longer hold: the manifest pinned at
manifest_version: 3, and ajqread inspawn-brood's liveness guard, which has since been removed.This PR applies the same pointer-form approach used for ADR-0018 in #376:
plugin/references/brood-ledger-model.md, and the inputs-file transport atplugin/governance/security-policy.md("Inert Inputs-File Navigator Pattern").Append-only: 14 insertions, 0 deletions.
Scope decisions
Validation
bash tools/validate.sh --changed: PASS.policy_check.sh --strictpassed 72 of 73 checks, with 29 allowlisted findings and 0 new (baseline).Versioning
No version bump. This is a docs-only change outside
plugin/, so the plugin stays at 4.1.0.