fix(lint): move test-only glob cache helpers to _test.go#33
Merged
Conversation
staticcheck reported globCacheLen and resetGlobCache as unused (U1000) because they only exist for tests. Move them to a _test.go file so they're excluded from production analysis. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
| Filename | Overview |
|---|---|
| internal/approval/glob_test_helpers_test.go | New file containing globCacheLen and resetGlobCache helpers moved from manager.go. Correctly placed in _test.go to fix staticcheck U1000 lint. Functions properly access unexported globCache fields via same-package test file. |
| internal/approval/manager.go | Removed two test-only helper functions (globCacheLen, resetGlobCache). Leaves a minor extra blank line but no functional issues. |
Reviews (2): Last reviewed commit: "fix(lint): move test-only glob cache hel..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
globCacheLenandresetGlobCachefrommanager.goto a newglob_test_helpers_test.gofileTest plan
go build ./internal/approval/passesgo vet ./internal/approval/passesgo test ./internal/approval/passesstaticcheck ./internal/approval/no longer reports U1000🤖 Generated with Claude Code