Use path as _id in mongodb, code formatting, standardisation and working with latest api-designer#2
Open
cymantic wants to merge 2 commits intobrianmc:masterfrom
cymantic:develop
Open
Use path as _id in mongodb, code formatting, standardisation and working with latest api-designer#2cymantic wants to merge 2 commits intobrianmc:masterfrom cymantic:develop
cymantic wants to merge 2 commits intobrianmc:masterfrom
cymantic:develop
Conversation
…ckage, use lib folder, not routes
Owner
|
Thanks for the PR Tom, lots of good improvements. Just interested in the move of files.js from routes to lib. I'm fairly new to node so just wondering if you were following a standard node/express organization convention and what that was. Thanks, Brian |
Author
|
I think lib is more standard from whenever I've used express (or sinatra), especially for files that provide additional functionality. I've never used a routes folder, but if you had a large app with extra routing config, then those files would go there. |
|
@brianmc What's the status on this merge? Is this project being actively worked on? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the _id to be the path to the file in mongodb
Also a few other formatting and renaming of files