Update ImagePaletteServiceProvider.php#9
Open
manticorp wants to merge 3 commits intobrianmcdo:masterfrom
Open
Conversation
|
@manticorp I tried your update but it isn't working for Laravel 5.3 and 5.4. I had to change it to: $this->app->singleton('image-palette', function () {
return new Client;
}); |
Author
|
Yes this is true actually - the array access set doesn't set a shared binding, but a call to singleton does - nicely spotted. |
|
One more thing: To support Laravel 5 you need to remove the line |
Author
|
Aha fair game - thanks for the heads up - have again updated :) |
|
Thanks for the FAST updates! This last update also fixes issue #6. I hope this pull request is merged soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it compatible with the current latest version of laravel, which removed the share method from the application container.