Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2756 +/- ##
==========================================
- Coverage 96.64% 96.62% -0.03%
==========================================
Files 201 201
Lines 20440 20444 +4
Branches 525 525
==========================================
- Hits 19754 19753 -1
- Misses 570 574 +4
- Partials 116 117 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
briansmith
force-pushed
the
b/getrandom-0.4
branch
3 times, most recently
from
fe86f46 to
dc5efe7
Compare
briansmith
changed the title
Owner
Author
|
Rust 2024 changes will be done in a separate PR. |
Owner
Author
|
The "1.85" MSRV tests in CI need to be updated to use the MSRV-aware resolver, I guess, as otherwise an indirect downstream dependency requires 1.87. |
briansmith
force-pushed
the
b/getrandom-0.4
branch
9 times, most recently
from
52f7512 to
7c24aea
Compare
getrandom 0.4.1 seems to have implemented good enough support with its wasm_js feature to make it usable as an alternative to getrandom 0.2. getrandom 0.4 raised its MSRV to 1.85, so raise ours to MSRV 1.85. getrandom 0.4 has dependencies with MSRV 1.87 or later, so we *must use `incompatible-rust-versions = "fallback"` during MSRV testing, at least for wasm32-wasip2. Rust 1.84 (and getrandom 0.3) dropped support for the old wasm32-wasi target, and won't build for that target, so stop supporting it. Deal with MSRV.
briansmith
force-pushed
the
b/getrandom-0.4
branch
2 times, most recently
from
f1c46e4 to
affe555
Compare
briansmith
force-pushed
the
b/getrandom-0.4
branch
from
affe555 to
5bf9369
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.