Exclude development scripts from published package#70
Open
weiznich wants to merge 1 commit intobriansmith:mainfrom
Open
Exclude development scripts from published package#70weiznich wants to merge 1 commit intobriansmith:mainfrom
weiznich wants to merge 1 commit intobriansmith:mainfrom
Conversation
briansmith
reviewed
Dec 16, 2025
Cargo.toml
Outdated
| readme = "README.md" | ||
| repository = "https://github.com/briansmith/untrusted" | ||
| version = "0.9.0" | ||
| include = ["Cargo.toml", "README.md", "LICENSE.txt", "src/**/*.rs"] |
Owner
There was a problem hiding this comment.
I think we should include tests/ as well, at least until we have a better way of packaging the tests (in their own crate) for people who want to run dependencies' tests in their own CI. WDYT?
Author
There was a problem hiding this comment.
I added the tests directory as well.
I personally prefer it to be excluded as almost all users won't use it, but again it doesn't hurt having it here
During a dependency review we noticed that the untrusted crate includes various development scripts. These development scripts shouldn't be there as they might, at some point become problematic. As of now they prevent any downstream user from enabling the `[bans.build.interpreted]` option of cargo deny. I opted for using an explicit include list instead of an exclude list to prevent these files from beeing included in the published packages to make sure that everything that's included is an conscious choice.
weiznich
force-pushed
the
exclude_scripts
branch
from
483045b to
40c20ec
Compare
Author
|
@briansmith Did the update address your concern? Is there anything needed from my side to get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a dependency review we noticed that the untrusted crate includes various development scripts. These development scripts shouldn't be there as they might, at some point become problematic. As of now they prevent any downstream user from enabling the
[bans.build.interpreted]option of cargo deny.I opted for using an explicit include list instead of an exclude list to prevent these files from beeing included in the published packages to make sure that everything that's included is an conscious choice.