Skip to content

fix(#430): per-account authorized_controller in AccountInitRequest - #570

Merged
phertyameen merged 1 commit into
bridgelet-org:mainfrom
abdoolyaro:fix/430-431-per-account-controller
Aug 28, 2026
Merged

fix(#430): per-account authorized_controller in AccountInitRequest#570
phertyameen merged 1 commit into
bridgelet-org:mainfrom
abdoolyaro:fix/430-431-per-account-controller

Conversation

@abdoolyaro

Copy link
Copy Markdown
Contributor

closes #430
closes #431

…nitRequest

- AccountInitRequest now carries authorized_controller so batch_initialize
  can wire each account to a distinct controller (e.g. a real
  SweepController instance) instead of hardcoding creator
- fixes bridgelet-org#431: account_factory/src/test.rs was never wired into the crate
  (missing mod test declaration and a cfg(test) gate), so its tests
  including the existing e2e pipeline test for bridgelet-org#431 silently never ran
- fixes an invalid checksum on the hardcoded admin placeholder address
  that broke every batch_initialize call once the test module was
  actually wired in
- fixes a u32 underflow and an Option<u8>-as-u32 cast bug in
  src/test.rs, both latent in code that had never compiled before
- adds test_batch_initialize_wires_distinct_authorized_controller_per_request
  as a direct regression test for the controller-hardcoding bug
@drips-wave

drips-wave Bot commented Aug 28, 2026

Copy link
Copy Markdown

@abdoolyaro Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@phertyameen
phertyameen merged commit d9fbd15 into bridgelet-org:main Aug 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants