fix(#430): per-account authorized_controller in AccountInitRequest - #570
Merged
phertyameen merged 1 commit intoAug 28, 2026
Merged
Conversation
…nitRequest - AccountInitRequest now carries authorized_controller so batch_initialize can wire each account to a distinct controller (e.g. a real SweepController instance) instead of hardcoding creator - fixes bridgelet-org#431: account_factory/src/test.rs was never wired into the crate (missing mod test declaration and a cfg(test) gate), so its tests including the existing e2e pipeline test for bridgelet-org#431 silently never ran - fixes an invalid checksum on the hardcoded admin placeholder address that broke every batch_initialize call once the test module was actually wired in - fixes a u32 underflow and an Option<u8>-as-u32 cast bug in src/test.rs, both latent in code that had never compiled before - adds test_batch_initialize_wires_distinct_authorized_controller_per_request as a direct regression test for the controller-hardcoding bug
|
@abdoolyaro Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
phertyameen
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #430
closes #431